Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed layout handle for cms page #9247

Merged
merged 1 commit into from
Apr 19, 2017
Merged

Fixed layout handle for cms page #9247

merged 1 commit into from
Apr 19, 2017

Conversation

simpleadm
Copy link
Contributor

@simpleadm simpleadm commented Apr 14, 2017 •
edited by okorshenko
Loading

Description

Cms module adds additional layout update handle with identifier on page view. Following problems appear when user use slashes in page identifier (e.g. cms/page):

  1. Impossible to use custom layout update file (e.g. cms_page_view_id_cms_page)
  2. Menu missing when varnish full page cache enable (relevant only for 2.0 and 2.1 branches)
  3. Wrong layout handle format

Manual testing scenarios

  1. Enable varnish full page cache under Stores > Configuration > Advanced > System > Full Page Cache > Caching Application
  2. Create new cms page
  3. Provide URL Key with slashes (e.g. cms/page)
  4. Check result on frontend (menu will be missing)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Apr 14, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@okorshenko okorshenko self-assigned this Apr 14, 2017
@okorshenko okorshenko added this to the April 2017 milestone Apr 14, 2017
@magento-team magento-team merged commit f7cd995 into magento:develop Apr 19, 2017
magento-team pushed a commit that referenced this pull request Apr 19, 2017
@vrann
MAGETWO-67492: Fixed layout handle for cms page #9247
a1ab32d
@magento-team
Copy link
Contributor

@simpleadm Thank you for the contribution

@simpleadm simpleadm mentioned this pull request Feb 5, 2018
Merged
magento-engcom-team pushed a commit that referenced this pull request Feb 7, 2018
@orlangur
MAGETWO-87443: [Backport 2.1] #9247 fixed layout handle for cms page #…
dc647e1 
…13489

 - Merge Pull Request #13489 from simpleadm/magento2:backport/fix-cms-page-layout-handles
 - Merged commits:
   1. 0d1be23
magento-engcom-team pushed a commit that referenced this pull request Feb 7, 2018
MAGETWO-87443: [Backport 2.1] #9247 fixed layout handle for cms page #…
cb9053e 
…13489
magento-engcom-team pushed a commit that referenced this pull request Feb 7, 2018
🔃 [EngCom] Public Pull Requests - 2.1-develop
7fa17f3 
Accepted Public Pull Requests:
 - #13489: [Backport 2.1] #9247 fixed layout handle for cms page (by @simpleadm)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okorshenko okorshenko

Labels
None yet
Projects
None yet
Milestone
April 2017
Development

Successfully merging this pull request may close these issues.
4 participants
@simpleadm @magento-cicd2 @magento-team @okorshenko